Emit retags in codegen to support BorrowSanitizer (part 4)#158100
Open
icmccorm wants to merge 4 commits into
Open
Emit retags in codegen to support BorrowSanitizer (part 4)#158100icmccorm wants to merge 4 commits into
icmccorm wants to merge 4 commits into
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
saethlin
reviewed
Jun 21, 2026
saethlin
reviewed
Jun 27, 2026
Comment on lines
+354
to
+356
| // If the variant contains another variant, then the current block | ||
| // will be different than the one that we created above. We want this | ||
| // block to jump to the terminator block. |
Member
There was a problem hiding this comment.
I don't think this is quite right. For example:
#![crate_type = "lib"]
pub enum Inner {
A(&'static u8),
B(&'static u16),
}
pub enum Outer {
P(&'static u32),
Q(Inner),
}
#[inline(never)]
pub fn demo(_x: Outer) {}produces a block for the Outer::Q case that recurses into the Inner, but that block has no predecessors.
Contributor
Author
There was a problem hiding this comment.
Good catch! This should be fixed now with 19ba1b0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #154760
Zulip Thread
This is one of several PRs that add experimental support for emitting retags as function calls in codegen.
This PR emits our retag intrinsics based on the structure of a
RetagPlan. The feature works end-to-end now! But, it has two limitations:We do not track interior mutable or pinned ranges precisely. This will come in the next PR, which should be the last one that we need to complete this feature (excluding documentation and compile tests).
We recurse into
repr(simd)types when building aRetagPlan, but we do not emit retags for their fields. We would needBuilderMethods::insert_element, which isn't available. I'm not sure what the best workaround would be for this.Related: #157825, #156210, #156208
Cc: @RalfJung
r? @saethlin